Skip to content

Possibly fix #218 - next->_next might be unavailble. #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zeyus
Copy link
Contributor

@zeyus zeyus commented Apr 10, 2025

When cur is deleted, next might become invalid. I've run this test locally and it passes, but I also couldn't get it to fail with the previous implementation, but I see it failing in the test outputs.

If this invokes the test runner we can see if the issue persisits.

@zeyus zeyus marked this pull request as draft April 10, 2025 14:59
@zeyus
Copy link
Contributor Author

zeyus commented Apr 11, 2025

@cboulay for your consideration.

I don't know exactly where it's going wrong, but for example if i close all the inlets in a loop (without deleting them) then the first works, and each subsequent stream_close results in:

(  17.861s) [R_cf_double64   ]      data_receiver.cpp:344    ERR| Stream transmission broke off (Input stream error.); re-connecting...

e.g. for the inlets_10, there'll be that message 9 times.

I don't know if this indicates a problem with the inlets sharing some pointer?

How it is now, the tests pass, and my idea of copying the stream_info is probably not at all related to it.

I'd be happy to make this into a fully fledged PR but I'd prefer to actually understand the problem rather than guess :)

@zeyus
Copy link
Contributor Author

zeyus commented Apr 11, 2025

oh and for the sample destructor, obviously performance is super critical, while .load should give some additional safety (if that is even where the problem really is), I guess there's a slight overhead as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant