Conversation
|
@cboulay for your consideration. I don't know exactly where it's going wrong, but for example if i close all the inlets in a loop (without deleting them) then the first works, and each subsequent stream_close results in: e.g. for the inlets_10, there'll be that message 9 times. I don't know if this indicates a problem with the inlets sharing some pointer? How it is now, the tests pass, and my idea of copying the stream_info is probably not at all related to it. I'd be happy to make this into a fully fledged PR but I'd prefer to actually understand the problem rather than guess :) |
|
oh and for the sample destructor, obviously performance is super critical, while |
When cur is deleted, next might become invalid. I've run this test locally and it passes, but I also couldn't get it to fail with the previous implementation, but I see it failing in the test outputs.
If this invokes the test runner we can see if the issue persisits.