Skip to content

Fix extra garbage sample transmitted when outlet is destroyed #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cboulay merged 4 commits into from
Jan 11, 2026
Merged

Fix extra garbage sample transmitted when outlet is destroyed #246

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6936f6d
maybe
mscheltienne Jan 6, 2026
5288f61
more ai-generated fix
mscheltienne Jan 7, 2026
3067ff0
revert fix to trigger failure on CI
mscheltienne Jan 7, 2026
bd17ac2
Revert "revert fix to trigger failure on CI"
mscheltienne Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/tcp_server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,9 @@ void tcp_server::end_serving() {
});
// issue closure of all active client session sockets; cancels the related outstanding IO jobs
close_inflight_sessions();
// also notify any transfer threads that are blocked waiting for a sample by sending them one (=
// a ping)
send_buffer_->push_sample(factory_->new_sample(lsl_clock(), true));
// also notify any transfer threads that are blocked waiting for a sample by pushing an empty
// sample pointer (the threads check for !samp and skip it, see transfer_samples_thread)
send_buffer_->push_sample(sample_p());
}

// === accept loop ===
Expand Down
Loading