Fix assertions in PersistentTextureRequestsExample #737
Open
skalarproduktraum wants to merge 3 commits intomainfrom
Open
Fix assertions in PersistentTextureRequestsExample #737skalarproduktraum wants to merge 3 commits intomainfrom
skalarproduktraum wants to merge 3 commits intomainfrom
Conversation
… issue after renderer shutdown with counting in runAfterRender lambda
skalarproduktraum
force-pushed
the
fix/persistent-texture-example-assertions
branch
from
f2827ba to
1b80c07
Compare
Member
aryaman-gupta
left a comment
aryaman-gupta
left a comment
There was a problem hiding this comment.
One minor comment, looks good to me otherwise!
| val sum = file.readBytes().sum() | ||
| logger.info("Dumped: $file, ${file.length()} bytes, sum=$sum") | ||
| assertEquals(file.length(), 1280*720*4, "File should contain the correct number of bytes for a 1280x720xRGBA image") | ||
| assert(sum > 3000000) { "Sum of bytes in file should be non-zero" } |
Member
There was a problem hiding this comment.
Why is the sum compared with 3000000? Is it not sufficient to check that it is not equal to zero? Changes in volume rendering code down the line could change the image generated and therefore the sum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with semi-deterministic assertions in PersistentTextureRequestsExample and replaces those with deterministic assertions run in a runAfterRender lambda.