4 avoid duplicates #120
Open
4 avoid duplicates #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deradre
force-pushed
the
4-avoid-duplicates
branch
from
ef79c25 to
ae3fd62
Compare
- write watch list titles as JSON to DOM, to have them available at browser runtime - don't render add button at suggestion items, if already in watch list - don't add titles if already on watchlist
add button that jumps to movie in the list if the chosen movie already exists.
- make our frontend js es6 modules so they can easily be consumed in tests - move most js code from app.js to title.js - introduce moveez.js that sets up a global moveez namespace and attaches it to the window object
deradre
force-pushed
the
4-avoid-duplicates
branch
from
86d3119 to
6f27590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.