Skip to content

Fix CMake race condition in parallel builds #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jreniel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix CMake race condition in parallel builds #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59e2ddf
fix Fortran module race condition in parallel builds
jreniel Dec 16, 2025
58f33b1
update CMake policy CMP0074 from OLD to NEW
jreniel Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ cmake_minimum_required (VERSION 3.12)
set(CMAKE_DISABLE_SOURCE_CHANGES ON)
set(CMAKE_DISABLE_IN_SOURCE_BUILD ON)

# This policy has to do with variables called <module>_ROOT
# and possible collisions with module-finding.
cmake_policy(SET CMP0074 OLD)
# CMP0074: find_package() uses <PackageName>_ROOT variables
cmake_policy(SET CMP0074 NEW)


enable_testing()
Expand Down
11 changes: 6 additions & 5 deletions src/Utility/ArcGIS/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@


add_executable( binary_2_ncstruc binary_2_ncstruc.f90)

#add_executable( read_output7b_group_zfs2 read_output7b_group_zfs2.f90)


target_link_libraries (binary_2_ncstruc ${NetCDFLIBS} ${HDF5_LIBRARIES} schism_geometry)
add_dependencies(utility binary_2_ncstruc read_output7b_group_zfs2)
# Link to utillib which contains stripesearch_unstr.f90 (called by binary_2_ncstruc)
target_link_libraries(binary_2_ncstruc ${NetCDFLIBS} ${HDF5_LIBRARIES} utillib)
target_include_directories(binary_2_ncstruc PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/../UtilLib)
# Add dependency on utillib to ensure it's built before compilation
add_dependencies(binary_2_ncstruc utillib)
add_dependencies(utility binary_2_ncstruc)

5 changes: 5 additions & 0 deletions src/Utility/Grid_Scripts/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,8 @@ add_executable(mergegrid5 mergegrid5.f90)
target_link_libraries(mergegrid5 utillib)
target_include_directories(mergegrid5 PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/../UtilLib)
add_dependencies(mergegrid5 utillib)

# Add dependency on utillib for executables that define their own modules
# to ensure utillib modules are built first and avoid race conditions
# when multiple targets write .mod files to the shared include directory
add_dependencies(interpolate_unstructured utillib)
2 changes: 2 additions & 0 deletions src/Utility/Particle_Tracking/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,7 @@ add_executable(ptrack3 ptrack3.f90)
add_dependencies(utility ptrack3) ## ptrack4)
target_link_libraries(ptrack3 utillib ${NetCDFLIBS} ${HDF5_LIBRARIES})
target_include_directories(ptrack3 PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/../UtilLib)
# Add dependency on utillib to ensure Fortran .mod files exist before compilation
add_dependencies(ptrack3 utillib)
#target_link_libraries(ptrack4 utillib ${NetCDFLIBS} ${HDF5_LIBRARIES})
#target_include_directories(ptrack4 PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/../UtilLib)
12 changes: 12 additions & 0 deletions src/Utility/Pre-Processing/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,15 @@ target_link_libraries(gen_nudge_from_hycom utillib ${NetCDFLIBS} ${HDF5_LIBRARIE
target_include_directories(gen_vqs_1 PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/../UtilLib)
target_include_directories(gen_vqs_2masters PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/../UtilLib)
target_include_directories(gen_nudge_from_hycom PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/../UtilLib)

# Add dependencies on utillib for targets that use utillib modules
# to ensure Fortran .mod files exist before compilation
add_dependencies(convert_3Dth_nc utillib)
add_dependencies(convert_nudge_nc utillib)
add_dependencies(gen_vqs_1 utillib)
add_dependencies(gen_vqs_2masters utillib)
add_dependencies(gen_nudge_from_hycom utillib)

# Add dependency for gen_source which defines its own 'module global'
# to avoid race conditions with other modules in the shared include directory
add_dependencies(gen_source utillib)