Skip to content

Unify usage "default system"#164

Open
h3lg3 wants to merge 3 commits intomainfrom
add_system_to_seqs
Open

Unify usage "default system"#164
h3lg3 wants to merge 3 commits intomainfrom
add_system_to_seqs

Conversation

@h3lg3
Copy link
Copy Markdown
Collaborator

@h3lg3 h3lg3 commented Apr 1, 2026

This PR unifies the usage of default_system for all sequences. Also fixes docstrings by removing "optional" and "default" comments as this is not recommended. Also adapts the default system to standard settings used for sequence programming.

h3lg3 added 2 commits April 1, 2026 11:27
- removes optional and default descriptions in docstrings
- changes default system to match standard values for sequence programming
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/console
   __init__.py10190%11
src/console/interfaces
   acquisition_data.py1232580%96–99, 110–111, 129–130, 145–148, 158–159, 188–189, 193–199, 215–216, 227, 231, 249
   acquisition_parameter.py107496%126, 163, 178, 213
   device_configuration.py55296%61, 67
   dimensions.py962277%45–46, 67–68, 71, 79, 89, 95, 101, 107, 113–115, 125–127, 137–139, 149–151
   rx_data.py861879%77–81, 89, 101, 105, 107, 122, 130–135, 143, 151, 154, 157
src/console/pulseq_interpreter
   sequence_provider.py2281494%100, 247–248, 344–345, 456, 506–507, 576, 602–603, 619, 628, 632
src/console/spcm_control
   abstract_device.py79790%2–149
   acquisition_control.py1561560%3–365
   rx_device.py2092090%2–493
   tx_device.py1751750%2–465
src/console/spcm_control/spcm
   pyspcm.py1611610%3–295
   tools.py54540%3–128
src/console/utilities
   json_encoder.py8362%22–24
   load_configuration.py20670%18–20, 28–30
   plot.py531670%31–32, 80–98
src/console/utilities/data
   mrd_helper.py43881%37, 43, 49, 52, 60, 63, 68, 71
   write_acquisition_to_mrd.py49590%43–44, 68, 86, 91
src/console/utilities/sequences/calibration
   fid_tx_adjust.py23196%70
   se_tx_adjust.py30293%66–68
src/console/utilities/sequences/spectrometry
   fid.py13192%46
   se_spectrum.py26292%55, 111
src/console/utilities/sequences/tse
   tse_3d.py2427569%121–122, 124–125, 127–128, 135–136, 138–140, 142–145, 156–159, 164–167, 174–185, 202, 224–231, 237, 268, 331–348, 355–356, 423, 426–438, 546–557
TOTAL5304103980% 

Tests Skipped Failures Errors Time
193 0 💤 0 ❌ 0 🔥 19.852s ⏱️

@h3lg3 h3lg3 requested a review from schote April 1, 2026 09:37
@h3lg3
Copy link
Copy Markdown
Collaborator Author

h3lg3 commented Apr 1, 2026

Locally the Static Tests succeeded after running python3 -m pip install types-PyYAML but I dont know how to fix it for the repo.

(console-env) C:\Users\hhert\Git-projects\nexus-console>mypy src
Success: no issues found in 45 source files

Copy link
Copy Markdown
Owner

@schote schote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default system settings specify block duration raster of 1e-6, I would suggest to also harmonize the exemplary device config in this PR and define identical raster times.

@h3lg3 h3lg3 requested a review from schote April 1, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants