Open
Conversation
- removes optional and default descriptions in docstrings - changes default system to match standard values for sequence programming
Collaborator
Author
|
Locally the |
schote
reviewed
Apr 1, 2026
Owner
schote
left a comment
There was a problem hiding this comment.
The default system settings specify block duration raster of 1e-6, I would suggest to also harmonize the exemplary device config in this PR and define identical raster times.
update example device config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unifies the usage of default_system for all sequences. Also fixes docstrings by removing "optional" and "default" comments as this is not recommended. Also adapts the default system to standard settings used for sequence programming.