-
Notifications
You must be signed in to change notification settings - Fork 2
Culling packages #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 60 commits
64777ea
4074ed3
6ffc064
caf8b90
d7ae7f4
ed89291
5eb5055
ad5883d
6e65f09
e443d1e
e5e9ca3
a74b6ac
b3e6af6
df26d05
a95a1ee
6c82ec8
f5d1ed7
0cfed07
11a1ee2
e31e566
cd1a84a
b14450f
78ae736
dbf063a
3aee757
41ce625
cc4cff0
1935ff5
4949a73
c80dd6e
f2e5413
4c1922f
80cdbd2
2df35db
1c997e0
9aafb61
d0a16d1
cbe1850
6408e2d
63ebdb2
980cd60
ea3b209
9bc9a7b
851e43e
d0956a8
33daf04
859d33d
a4f46c0
3ef0a42
baa6d3b
0417c41
6dc2317
538c0e7
4f7a102
ea81bb7
8aab8f2
4fe5b9b
63d5425
8cdb7fb
32eb78d
d25b51f
fd4cc04
3a6d5b3
b9e2385
c80e731
53f7c38
c6d3362
efc3069
91e470a
d84a006
1858f53
da4f79c
b0c6855
fb8f0df
32f42b2
7e40243
0fd3594
40b9963
91f21ea
75352ae
db4b841
1d33a10
7ceb5a9
47abb53
f203422
f7b451a
5e05d23
7e0d695
1c3bb07
aac7c8e
d6619e9
c605777
e237bf3
782690b
78c320a
6dc0750
72e4544
0cf7452
be8494a
1bd472d
8754bf5
dfb6c62
51cf331
6a90ad2
6b104bc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,3 +7,4 @@ tests/.joblib_cache | |
| .pytest_cache | ||
| .DS_Store | ||
| __pycache__ | ||
| conda-bld/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Makefile targets for local build steps on Mac. | ||
| SHELL := bash | ||
| MENU_PKG_NAME=sp-installer-menu | ||
| ROOT_PREFIX=$(shell conda config --show root_prefix | cut -d ' ' -f 2) | ||
| ENV_PKGS=$(ROOT_PREFIX)/pkgs | ||
|
|
||
| UNAME := "$(shell uname -s)" | ||
| ifeq ($(findstring Linux,$(UNAME)),Linux) | ||
| MACHINE=Linux | ||
| else ifeq ($(findstring Darwin,$(UNAME)),Darwin) | ||
| MACHINE=macOS | ||
| else ifeq ($(findstring MINGW64_NT,$(UNAME)),MINGW64_NT) | ||
| MACHINE=Windows | ||
| else ifeq ($(FINDSTRING MSYS_NT,$(UNAME)),MSYS_NT) | ||
| MACHINE=Windows | ||
| else | ||
| MACHINE="UNKNOWN:$(UNAME)" | ||
| endif | ||
|
|
||
| all: menu-pkg installer | ||
|
|
||
| menu-pkg: | ||
| conda-build $(MENU_PKG_NAME) --no-test --no-anaconda-upload --croot conda-bld | ||
drammock marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| installer: | ||
| constructor recipes/scientific-python | ||
|
|
||
| install: | ||
| installer -pkg Scientific-Python-*.pkg -target CurrentUserHomeDirectory | ||
|
|
||
| clean: | ||
| @rm -rf conda-bld | ||
| @rm -rf ~/.conda/constructor/*/$(MENU_PKG_NAME)* | ||
| @if [[ $(MACHINE) == "macOS" ]]; then \ | ||
| rm -rf ~/Applications/*Scientific*; \ | ||
| rm -f Scientific-Python-*.pkg; \ | ||
| elif [[ $(MACHINE) == "Linux" ]]; then \ | ||
| rm -rf $(HOME)/Scientific-Python/*; \ | ||
| rm -f ./Scientific-Python-*.sh; \ | ||
| rm -f $(HOME)/.local/share/applications/scientific-python-*.desktop; \ | ||
| elif [[ $(MACHINE) == "Windows" ]]; then \ | ||
| echo "TODO cleanup Windows icons"; \ | ||
| fi | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ | |
| \pard\pardeftab720\partightenfactor0 | ||
| \f1\b0 \cf2 \ | ||
| Copyright \'a9 MNE-Python Developers\ | ||
| Copyright \'a9 Scientific Python Developers\ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should acknowledge "MNE-Python Developers" here too, no? |
||
| All rights reserved.\ | ||
| \ | ||
| Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:\ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| BSD 3-Clause License | ||
|
|
||
| Copyright (c) MNE-Python Developers | ||
| Copyright (c) Scientific Python Developers | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto on acknowledging MNE-Python devs too |
||
| All rights reserved. | ||
|
|
||
| Redistribution and use in source and binary forms, with or without | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IIRC this logo ended up not looking super good in the macOS installer (shoved too far into the corner). mentioning as a TODO for later. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,3 +10,4 @@ dependencies: | |
| - menuinst | ||
| - conda >=23.11.0 | ||
| - fmt !=10.2.0 | ||
| - conda-build | ||
Uh oh!
There was an error while loading. Please reload this page.