Skip to content

BUG: defaulting to UTC tz rather than to None #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −3
Open

BUG: defaulting to UTC tz rather than to None #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60fe287
BUG: defaulting to UTC tz rather than to None
bsipocz Jul 29, 2025
17dc6c7
BUG: again, default tz to UTC
bsipocz Jul 29, 2025
1017695
MAINT: ignore ruff
bsipocz Jul 29, 2025
7454841
MAINT: this really is becoming ridiculous
bsipocz Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ ignore = [
"ARG001", # Unused function argument
"PT012", # `pytest.raises()` block
"PLW0129", # Asserting on a non-empty string literal will always pass
"SIM108", # Use ternary operator instead of `if`-`else`-block
]

[tool.pytest.ini_options]
Expand Down
10 changes: 7 additions & 3 deletions yaml2ics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,18 +45,20 @@ def utcnow():
# This function can be used to add a list of e.g. exception dates (EXDATE) or
# recurrence dates (RDATE) to a reoccurring event
def add_recurrence_property(
event: ics.Event, property_name, dates: map, tz: datetime.tzinfo = None
event: ics.Event, property_name, dates: map, tz: datetime.tzinfo = dateutil.tz.UTC
):
event.extra.append(
ics.ContentLine(
name=property_name,
params={"TZID": [str(ics.Timezone.from_tzinfo(tz))]} if tz else None,
params={"TZID": [str(ics.Timezone.from_tzinfo(tz))]},
value=",".join(dates),
)
)


def event_from_yaml(event_yaml: dict, tz: datetime.tzinfo = None) -> ics.Event:
def event_from_yaml(
event_yaml: dict, tz: datetime.tzinfo = dateutil.tz.UTC
Copy link
Member

@stefanv stefanv Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either change the default, or change the handling below, but not both.

Copy link
Member Author

@bsipocz bsipocz Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel it makes most sense to change the default here, and then let the event timezone overwrite. Or it maybe cleaner to drop the tz kwarg altogether and rely only on the yaml and have a conditional?

    if "timezone" in d:
        tz = gettz(d.pop("timezone"))
    else:
        tz = dateutil.tz.UTC

) -> ics.Event:
d = event_yaml
repeat = d.pop("repeat", None)
ics_custom = d.pop("ics", None)
Expand Down Expand Up @@ -171,6 +173,8 @@ def files_to_events(files: list) -> (ics.Calendar, str):
tz = calendar_yaml.get("timezone", None)
if tz is not None:
tz = gettz(tz)
else:
tz = dateutil.tz.UTC
if "include" in calendar_yaml:
included_events, _name = files_to_events(
os.path.join(os.path.dirname(f), newfile)
Expand Down
Loading