Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: propagate metadata (behavior & attrs) in _generalevent.py #333

Merged
merged 6 commits into from
Mar 17, 2025

Conversation

pfackeldey
Copy link
Contributor

(Hopefully) fixes #298

Can you give it a try (@jennetd & @lgray) ?

(Hm... It might be more correct to propagate behavior and attrs in each self.multi_layered_listoffset call, but I think it makes no difference here and thus I went with the smaller code change)

@lgray
Copy link
Collaborator

lgray commented Mar 17, 2025

there are a few other places where we should propagate attrs as well!

@lgray
Copy link
Collaborator

lgray commented Mar 17, 2025

but good catch!

@lgray
Copy link
Collaborator

lgray commented Mar 17, 2025

Just taking a look at it, multi_layered_listoffset_input needs the behaviors and such to be set for its assumptions in calling other functions to be met (if I'm reading this right).

So we should probably propagate there as well.

@pfackeldey
Copy link
Contributor Author

Great, this looks good to me! 👍

@lgray
Copy link
Collaborator

lgray commented Mar 17, 2025

The recent changes also fix the problem in the reproducer given.

Will go ahead and merge. I think we're ready for a release after this.

@lgray lgray enabled auto-merge (squash) March 17, 2025 18:11
@lgray lgray merged commit 36ed3c9 into main Mar 17, 2025
14 checks passed
@lgray lgray deleted the pfackeldey/fix_generalevent_metadata_propagation branch March 17, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems inputting PF candidate array to fastjet clustering
2 participants