Add support for sending failed logs to logdetective #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Pull Request validationFailed🔴 Failed or pending statuses:
🔴 Review - Missing review from a member (1 required) |
phracek
force-pushed
the
enable_logdetective
branch
from
55d624e to
a8e79f3
Compare
phracek
force-pushed
the
enable_logdetective
branch
from
a8e79f3 to
7d05253
Compare
phracek
force-pushed
the
enable_logdetective
branch
2 times, most recently
from
00e5e7a to
d49c91e
Compare
phracek
force-pushed
the
enable_logdetective
branch
from
d49c91e to
3e4f2ed
Compare
New function called 'analyze_logs_by_logdetective()' is
used as for 'build' part as for 'test' part.
Each function is marked by 'LOGDETECTIVE {BUILD|TEST} tag
so we can easily find them.
Also parsing logs have been enhanced no parse_output is needed.
Let's call it directly.
It is used on Fedora. We use podman for building
and there is no needed to use complicated functions.
Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
enable_logdetective
branch
from
3e4f2ed to
d5d33ce
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Testing Farm results
|
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
enable_logdetective
branch
from
39a69ff to
428c450
Compare
|
[test] |
Signed-off-by: Petr "Stone" Hracek <[email protected]>
|
[test] |
|
/auto-merge |
and at the end store it to $TMT_TEST_DATA directory so we see it in Testing Farm results Signed-off-by: Petr "Stone" Hracek <[email protected]>
phracek
force-pushed
the
enable_logdetective
branch
from
8572e51 to
195784a
Compare
|
After copyting logdetective output to $TMT_TEST_DATA dir let's test it again. [test] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for sending failed logs to logdetective
New function called 'analyze_logs_by_logdetective()' is used as for 'build' part as for 'test' part.
Each function is marked by 'LOGDETECTIVE {BUILD|TEST} tag so we can easily find them.
Also parsing logs have been enhanced no parse_output is needed. Let's call it directly.
It is used on Fedora. We use podman for building
and there is no needed to use complicated functions.