Make the tests more robust (avoid sleep) and use functions from test-lib.sh #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lib.sh Sleep was sometimes too short on slower machines, which caused tests to fail. Let's rather use waiting in a loop, which works nice in other containers. There are also some functions in the test-lib.sh that we can use and get rid of the code duplication.
phracek
reviewed
May 7, 2020
There was a problem hiding this comment.
Code LGTM. Most of the functions were deleted and used from container-common-scripts. Great. +1
Just small nit-pick. What about to move run and run_command functions into the container-common-scripts as well.
But it does not block this Pull Request. Tests are passing which is awesome.
|
[test-openshift] |
Right, makes sense. I've created an issue for this at sclorg/container-common-scripts#148 so we don't forget. |
|
Good, merging then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sleep was sometimes too short on slower machines, which caused tests to fail.
Let's rather use waiting in a loop, which works nice in other containers.
There are also some functions in the test-lib.sh that we can use and get rid
of the code duplication.