Macos ci #1339
Draft
Macos ci #1339
+90
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI run failed because for some reason it didn't manage to delete the temp directory it creates in |
|
Thanks for working on this! I think I've seen the temp dir removal issue myself as well. Would be great if we could figure out a workaround. If we can't, we should allow it to fail only on macOS. |
yedayak
force-pushed
the
macos-ci
branch
3 times, most recently
from
e94114a to
34a0d71
Compare
This is an interim hack to remove things from CI config unrelated to beating the test suite into shape on macOS, for a bit faster turnaround. To be cleaned up and properly integrated to check.yaml before merge.
brew/python doesn't like installing python packages globally: ``` error: externally-managed-environment × This environment is externally managed ```
For some reason, even though the test succeeds, the actual file isn't created like on linux. Maybe about versions/implementations of make?
Some of the files have unicode characters that can be represented in
multiple ways, so we normalize them. Specifically:
'e\u0301' ('e' + 'Combining Acute Accent') doesn't equal '\xe9' (LATIN SMALL
LETTER E WITH ACUTE) unless you normalize them.
yedayak
force-pushed
the
macos-ci
branch
2 times, most recently
from
af140a3 to
918e22d
Compare
vipw seems to have -d as an option on macos now. Partially reverts ccf7bf6 "test(dmesg,vipw): expect no options on macOS"
The usage output on macos is in bsd style, not gnu style
yedayak
force-pushed
the
macos-ci
branch
4 times, most recently
from
104623c to
f8fe593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #726