Updated old-style K&R declarations to ANSI C #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated function declarations from old-style K&R C to modern ANSI C style in multiple source files for better compatibility with modern compilers and improved code readability. Files modified: - include/fitsfile.h: Updated function prototypes - src/fitsfile.c: Converted 21 functions - src/hget.c: Converted 26 functions - src/hput.c: Converted 19 functions - src/imio.c: Converted 15 functions - src/range_parse.c: Converted 6 functions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
This completes the K&R to ANSI C conversion by updating all header files to match the function prototypes in the implementation files. Modern C compilers (gcc 15+) require proper function prototypes in headers. Changes: - include/imio.h: Updated 14 function declarations with full parameter lists - include/fitshead.h: Updated 40+ hget*/hput* and helper function declarations - include/fitsfile.h: Added fitsheadsize declaration, updated imswap functions - src/hget.c: Removed conflicting K&R forward declaration - src/hput.c: Removed 4 K&R forward declarations of ksearch - src/fitsfile.c: Removed K&R forward declaration of fitsheadsize - src/accelsearch.c: Fixed function pointer types with proper signatures - src/wapp_head_parse.c: Fixed forward declarations and include order - src/readfile.c: Fixed function pointer array type declaration Build now succeeds with gcc 15.1.0 on macOS with no errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
On macOS with gcc15 and gfortran from MacPorts, executables that link both C and Fortran code were getting duplicate /opt/local/lib/libgcc RPATH entries, causing dyld to abort with an error. Changes: - Restructured macOS-specific linker flags in meson.build - Added -Wl,-no_warn_duplicate_libraries flag for macOS - Added post-install script fix_rpath_duplicates.py to clean up any remaining duplicate RPATHs (defensive measure) This fixes errors like: dyld[75722]: duplicate LC_RPATH '/opt/local/lib/libgcc' in prepfold Tested on macOS 26.0 with gcc15 15.1.0 from MacPorts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
OK, I have looked this over and tried it on both an Apple Silicon Mac (with an older gcc) and an x86 MacBook (with gcc15) and it compiles and works on both. |
|
Thoughts on merging this? |
|
Yes! I'm almost certainly going to do it. I've just been traveling a ton and have been trying to catch up and I'm leaving again for another trip today! So maybe early next week? I did take a look at many of the changes and they look good. Thanks for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A system upgrade caused me to compile PRESTO with gcc 15, which seems to strictly enforce ANSI C, so the old code in PRESTO that used K&R C declarations started causing errors.
I used this as an excuse to try Claude Code and had it do the conversion.
The result is this pull request. It was done by AI, so it needs a careful review and some testing.