Skip to content

Conversation

@kmike
Copy link
Member

@kmike kmike commented Aug 17, 2022

Fixes #67.

I'm assuming @Gallaecio is not against it, based on scrapinghub/scrapy-poet#68 (comment) :)

@kmike kmike requested a review from BurnzZ August 17, 2022 10:51
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #68 (53b2c4a) into master (facd6d0) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 53b2c4a differs from pull request most recent head 550a061. Consider uploading reports for the commit 550a061 to get more accurate results

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          17       17           
  Lines         488      488           
=======================================
  Hits          487      487           
  Misses          1        1           
Impacted Files Coverage Δ
web_poet/utils.py 100.00% <ø> (ø)
web_poet/exceptions/http.py 100.00% <100.00%> (ø)
web_poet/fields.py 97.43% <100.00%> (ø)
web_poet/overrides.py 100.00% <100.00%> (ø)
web_poet/page_inputs/client.py 100.00% <100.00%> (ø)
web_poet/page_inputs/http.py 100.00% <100.00%> (ø)
web_poet/page_inputs/url.py 100.00% <100.00%> (ø)

Copy link
Contributor

@BurnzZ BurnzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the commit to the .git-blame-ignore-revs file.

Other than that, LGTM @kmike !

@kmike
Copy link
Member Author

kmike commented Aug 17, 2022

Let's add the commit to the .git-blame-ignore-revs file.

A good catch, thanks @BurnzZ!

@kmike kmike merged commit 583fe2c into master Aug 17, 2022
@kmike kmike deleted the black-std branch August 17, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use default black options

3 participants