fix typings: Add children prop - #169
Open
reyronald wants to merge 2 commits into
Open
Conversation
In React 18, the `React.Component` type no longer includes the `children` prop by default, so it needs to be included explicitly. See https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-typescript-definitions Without this change the `Screener` component cannot be used in React 18 without TypeScript compilation errors.
Collaborator
|
Hello @reyronald, thank you for reporting the issue along with the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In React 18, the
React.Componenttype no longer includes thechildrenprop by default, so it needs to be included explicitly.See https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-typescript-definitions
Without this change the
Screenercomponent cannot be used in React 18 without TypeScript compilation errors.