Open
Conversation
This turns the segment reading into a cached round-robin, as it will now load the segment in the background and save its value in memory. The ally list can now be changed dynamically through a couple of accessors as well.
Member
|
I want to like this but I have concerns. Caching all the ally data is going to add a lot of heap. Have you done profiling on potential heap usage increases, coinciding gc and cpu costs? @tiennou |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes from me trying to integrate it in OM, since it has its own segment manager, handles instantiation, etc.
The big changes are that any sort of segment access goes through protected methods (so supposedly you just subclass it and provide your own stuff), and loads the segments in a round-robin, so you can always look at the last state you saw from an ally. The rest is mostly style cleanups.
Better look at the individual commits. I can definitely slice and dice stuff if it feels not appropriate (I realize writing this that caching all that stuff makes it hard on the heap usage, for example).