fix: eth66 serve signature #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiweichi
requested review from
jonastheis,
Thegaram,
frisitano,
greged93 and
colinlyguo
jonastheis
reviewed
Aug 26, 2025
This reverts commit 3f3a980.
frisitano
reviewed
Sep 4, 2025
crates/database/migration/src/m20250820_141702_block_signature.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the issue reth doesn't include sig during block request, l2geth will fail the block validation of blocks requested from reth.
The solution is that we persist block signature to the database of rollup-node, retrieve and serve it during handling eth66 block request.
Corresponding issue: #261
Corresponding reth PR: scroll-tech/reth#331
Closes: #261
Closes: #248