-
Notifications
You must be signed in to change notification settings - Fork 624
[FIX] script for detecting plonky3gpu version #1730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a version-reporting target to two Makefiles and rewrites a helper script to derive plonky3-gpu version and commit from Cargo.lock instead of using Git. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant ZP as zkvm-prover/Makefile
participant GO as crates/gpu_override/Makefile
Dev->>ZP: make version (GO_TAG, GIT_REV, ZKVM_COMMIT)
ZP->>GO: make -C ../crates/gpu_override version<br/>(env: GO_TAG, GIT_REV, ZKVM_COMMIT)
GO->>GO: Compose string "${GO_TAG}-${GIT_REV}-${ZK_VERSION}"
GO-->>ZP: Echo version string
ZP-->>Dev: Print version string
sequenceDiagram
autonumber
actor User as Invoker
participant SH as print_plonky3gpu_version.sh
participant CL as Cargo.lock
User->>SH: Run script
SH->>CL: Read lines matching "plonky3-gpu"
SH->>SH: Parse highest version and commit<br/>(truncate commit to 7)
SH-->>User: Output version (line 1)
SH-->>User: Output short commit (line 2)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
OK (it will be irreverent soon since we are going to use the open sourced upstream openvm gpu later) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
crates/gpu_override/Makefile (1)
19-20
: Add PHONY + prefer printf for stable, parseable output
- Declare version as .PHONY to avoid collisions with a file named version.
- printf is safer than echo for strings that may begin with dashes.
version: - echo ${GO_TAG}-${GIT_REV}-${ZK_VERSION} + printf "%s-%s-%s\n" "${GO_TAG}" "${GIT_REV}" "${ZK_VERSION}"Optional: consider renaming PLONKY3_GPU_VERSION (it holds a commit, not a semver) to PLONKY3_GPU_COMMIT to reduce confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
crates/gpu_override/Makefile
(1 hunks)crates/gpu_override/print_plonky3gpu_version.sh
(1 hunks)zkvm-prover/Makefile
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: tests
🔇 Additional comments (1)
zkvm-prover/Makefile (1)
41-43
: Delegation LGTMTarget correctly forwards env and delegates to crates/gpu_override/version.
This PR fixed the broken script to detect plonky3gpu version. Also add an make entry for printing out the version string
Summary by CodeRabbit
New Features
Chores