[DO NOT MERGE] L3 Validium #164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
crate-chunk-circuit
github-actions
bot
removed
crate-chunk-circuit
* preliminary work * chore: clippy fix * update versioned public inputs * fix: compilation for crate/integration * fix: further changes to support integration tests * fix: dir name for validium * test: with euclid-v2 for older testdata * commitment * fix: update due to upstream --------- Co-authored-by: Zhuo Zhang <[email protected]>
github-actions
bot
added
crate-batch-circuit
lispc
reviewed
Sep 3, 2025
| #[rkyv(derive(Debug))] | ||
| pub struct BatchHeaderValidiumV1 { | ||
| /// The DA-codec version for the batch. | ||
| #[rkyv()] |
There was a problem hiding this comment.
now we use bincode. So rkyv traits are not needed.
lispc
reviewed
Sep 3, 2025
|
thinking whether it is easy to split this into smaller & meaningful PRs. no good idea yet.. |
|
ok. I will add XXWitness conversion (with Feynman) and test with 0.5.2 exe binary tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.