Allow Custom Feature Spaces in Dialogue (Addresses Issue #668) #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zethson
requested changes
Feb 17, 2025
Member
Zethson
left a comment
Zethson
left a comment
There was a problem hiding this comment.
Two minor comments. Generally looks good! Thank you
Member
|
Closing in favor of #712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses Issue #668 where users requested greater flexibility in specifying the feature space for the Dialogue implementation. Previously, the Dialogue function was limited to using PCA via the _pseudobulk_pca method, which prevented users from easily experimenting with or formally documenting the use of alternative feature reduction techniques.
Changes Introduced:
Refactored Feature Extraction:
The internal function call has been updated from _pseudobulk_pca to _pseudobulk_feature. Small adjustment to make the label flexible to the user.
Existing functionality has been preserved. For users who rely on the default PCA behavior, the changes maintain backward compatibility while offering an easy path to extend or replace the feature space as needed.
Testing & Verification:
Confirmed that the Dialogue function correctly applies the specified feature space.
Ran all existing tests to ensure no regressions in other parts of the codebase.