Skip to content

Conversation

@Zethson
Copy link
Member

@Zethson Zethson commented Sep 7, 2025

  • Replaces the existing scvi-tools implementation of the MLPClassifier with a pure Jax/Flax implementation
  • Removes the mandatory scvi-tools dependency and gates Scgen behind an import lookup

Signed-off-by: Lukas Heumos <[email protected]>
@github-actions github-actions bot added the enhancement New feature or request label Sep 7, 2025
Signed-off-by: Lukas Heumos <[email protected]>
Signed-off-by: Lukas Heumos <[email protected]>
Signed-off-by: Lukas Heumos <[email protected]>
Signed-off-by: Lukas Heumos <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2025

Codecov Report

❌ Patch coverage is 79.47368% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.74%. Comparing base (ea82c20) to head (f35aa79).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../_perturbation_space/_discriminator_classifiers.py 81.03% 33 Missing ⚠️
pertpy/tools/__init__.py 62.50% 3 Missing ⚠️
pertpy/tools/_perturbation_space/_simple.py 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
- Coverage   72.98%   72.74%   -0.25%     
==========================================
  Files          47       47              
  Lines        5474     5510      +36     
==========================================
+ Hits         3995     4008      +13     
- Misses       1479     1502      +23     
Files with missing lines Coverage Δ
pertpy/tools/_perturbation_space/_comparison.py 100.00% <ø> (ø)
...y/tools/_perturbation_space/_perturbation_space.py 87.43% <ø> (-0.07%) ⬇️
pertpy/tools/__init__.py 77.77% <62.50%> (-1.54%) ⬇️
pertpy/tools/_perturbation_space/_simple.py 75.60% <62.50%> (-0.03%) ⬇️
.../_perturbation_space/_discriminator_classifiers.py 81.97% <81.03%> (-7.40%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Lukas Heumos <[email protected]>
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson Zethson merged commit bdf962e into main Sep 7, 2025
2 of 4 checks passed
@Zethson Zethson deleted the feature/remove_scvi_tools branch October 12, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants