Skip to content

nan handling for continuous and categorical coloring #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Sonja-Stockhaus
Copy link
Collaborator

Fix coloring of shapes, labels and points when there are nan values in the vectors to color by

@Sonja-Stockhaus Sonja-Stockhaus linked an issue Mar 5, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (27878f1) to head (2c02cee).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   85.21%   85.51%   +0.29%     
==========================================
  Files           8        8              
  Lines        1759     1795      +36     
==========================================
+ Hits         1499     1535      +36     
  Misses        260      260              
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/render.py 97.14% <100.00%> (+0.24%) ⬆️
src/spatialdata_plot/pl/utils.py 78.40% <100.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sonja-Stockhaus Sonja-Stockhaus marked this pull request as ready for review March 26, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorical color obs column crashes the plotting
2 participants