Skip to content

render_shapes now respects the cmap parameter #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timtreis
Copy link
Member

No description provided.

@timtreis timtreis linked an issue Mar 27, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 74.54545% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.92%. Comparing base (27878f1) to head (faddcd7).

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/utils.py 70.21% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   85.21%   84.92%   -0.30%     
==========================================
  Files           8        8              
  Lines        1759     1784      +25     
==========================================
+ Hits         1499     1515      +16     
- Misses        260      269       +9     
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/render.py 96.38% <100.00%> (-0.52%) ⬇️
src/spatialdata_plot/pl/utils.py 78.19% <70.21%> (-0.15%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@Sonja-Stockhaus Sonja-Stockhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timtreis timtreis merged commit 7716d43 into main Apr 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmap parameter ignored for render_shapes
3 participants