Skip to content

Conversation

@timtreis
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.37%. Comparing base (17607ba) to head (f7887b6).

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/utils.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   84.42%   84.37%   -0.05%     
==========================================
  Files           8        8              
  Lines        2131     2144      +13     
==========================================
+ Hits         1799     1809      +10     
- Misses        332      335       +3     
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/basic.py 89.32% <ø> (ø)
src/spatialdata_plot/pl/utils.py 80.15% <76.92%> (-0.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timtreis timtreis requested a review from Zethson November 17, 2025 13:41
- uses: actions/checkout@v3
- name: Set up Python 3.12
uses: actions/setup-python@v5
- uses: actions/checkout@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v4
- uses: actions/checkout@v5

filter: blob:none
fetch-depth: 0
- name: Install uv
uses: astral-sh/setup-uv@v5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: astral-sh/setup-uv@v5
uses: astral-sh/setup-uv@v7

def _process_return(lines: Iterable[str]) -> Generator[str, None, None]:
for line in lines:
if m := re.fullmatch(r"(?P<param>\w+)\s+:\s+(?P<type>[\w.]+)", line):
m = re.fullmatch(r"(?P<param>\w+)\s+:\s+(?P<type>[\w.]+)", line)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did my walrus go? :(

The name of the shapes element to render. If `None`, all shapes elements in the `SpatialData` object will be
used.
color : ColorLike | None, optional
color : ColorLike | str | None, optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there types in the docstring?

license = "BSD-3-Clause"
maintainers = [
{name = "Tim Treis", email = "[email protected]"},
{ name = "Tim Treis", email = "[email protected]" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scverse email? lives longer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants