-
Notifications
You must be signed in to change notification settings - Fork 5
Added ability to pull date and location from EXIF on images. #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adding ability to display date/location from Exif data
Added checks for API Key missing or not working.
Put API checks in non-FS section
two things
the data returned from node helper doesn't contain the date of the image (copied .png from downloads folder) |
…r no date Added exifr to the package.json Fixed L.log typo to Log.log Added additional check in node_helper and MMM-ImagesPhotos for no date found. Node_helper will return a blank and MMM-ImagesPhotos will check for blank as well as undefined and null
Good catch. I adjusted accordingly. I've added some additional checks in case it doesn't find an exif date. |
Adde HEIC change from master
Adding error handling that was in upstream master
there are version conflicts, can you fix those. |
Added package-lock.json
I think that did it. I was just adding the last few commits you made into my code. |
readme url is there any readme update about the exif info? |
Yes, in my repository I've updated the readme (it is also updated to reference installing from my repository since it was unique to my changes). |
urs, but we would be merging into my repo |
Chaged back to sdetweil's information for installing. Note: I'm getting an error on load after latest MM update. Error when loading MMM-ImagesPhotos: Unexpected identifier 'config'
I've just updated the readme to reflect your repo info again. |
can you show the module config? |
Sure. Thanks for taking a look. I figured that's where it was too, but when I switch to your fork it doesn't kick up an error with the same config.
|
npm run config:check reports it too? we updated the syntax checker to catch literals in the wrong place, but i havent seen this on my system |
No.
[2025-07-01 17:56:29.538] [INFO] Checking config file /home/pi/MagicMirror/config/config.js ... |
I found the problem. At some point I messed up something in node_helper with a bad cut and paste. Working on fixing it now. |
Fixing the rest of the bad cut and paste
I've added ability to pull date and location from EXIF on images. I just realized there are a couple of more edits to make to the Readme, but all the config info is there. I'm submitting this as a pull request because your repository is more likely to be found and used.