Skip to content

Added ability to pull date and location from EXIF on images. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

gonzonia
Copy link

I've added ability to pull date and location from EXIF on images. I just realized there are a couple of more edits to make to the Readme, but all the config info is there. I'm submitting this as a pull request because your repository is more likely to be found and used.

@sdetweil
Copy link
Owner

two things

  1. the exifr lib is not listed in package.json , need npm install exifr, which updates package.json
  2. in MMM-ImagePhotos.js there are two lines with L.log should be Log.log

the data returned from node helper doesn't contain the date of the image (copied .png from downloads folder)
I don't know if there IS some exif data..

@sdetweil sdetweil added the enhancement New feature or request label Feb 28, 2025
…r no date

Added exifr to the package.json
Fixed L.log typo to Log.log
Added additional check in node_helper and MMM-ImagesPhotos for no date found. Node_helper will return a blank and MMM-ImagesPhotos will check for blank as well as undefined and null
@gonzonia
Copy link
Author

Good catch. I adjusted accordingly. I've added some additional checks in case it doesn't find an exif date.

Adde HEIC change from master
Adding error handling that was in upstream master
@sdetweil
Copy link
Owner

there are version conflicts, can you fix those.

@gonzonia
Copy link
Author

I think that did it. I was just adding the last few commits you made into my code.

@sdetweil
Copy link
Owner

readme url

is there any readme update about the exif info?

@gonzonia
Copy link
Author

gonzonia commented Jun 15, 2025

Yes, in my repository I've updated the readme (it is also updated to reference installing from my repository since it was unique to my changes).

@sdetweil
Copy link
Owner

urs, but we would be merging into my repo

Chaged back to sdetweil's information for installing. 

Note: I'm getting an error on load after latest MM update. 

 Error when loading MMM-ImagesPhotos: Unexpected identifier 'config'
@gonzonia
Copy link
Author

gonzonia commented Jul 1, 2025

I've just updated the readme to reflect your repo info again.
For some reason I'm getting an error on load though after the latest MM update -Error when loading MMM-ImagesPhotos: Unexpected identifier 'config'

@sdetweil
Copy link
Owner

sdetweil commented Jul 1, 2025

can you show the module config?

@gonzonia
Copy link
Author

gonzonia commented Jul 1, 2025

Sure. Thanks for taking a look. I figured that's where it was too, but when I switch to your fork it doesn't kick up an error with the same config.

`{
		module: "MMM-ImagesPhotos",
		position: "fullscreen_below",
		classes: 'SceneFamily SceneSam',
		config: {
			opacity: 0.9,
			animationSpeed: 0,
			updateInterval: 120000, //How often to 
			getInterval: 6000000, //How often to check directory?
			maxWidth: "100%",
			maxHeight: "100%",
			retryDelay: 2500,
			fill: true,   // fill around image with blurred copy of image
			blur: 10,   // only used if fill is true
			sequential: false,   // process the image list randomly
			sleepList: "SCREENSAVE_ENABLED", //Suspend when these notifications are recieved
			wakeList: "SCREENSAVE_DISABLED", //Resume when these notifications are recieved
			showExifDate: true,
			showDateLabel: false,
			BigDataGeoAPI:"XXXXXXXXXXXXX",
			showCity: true,
		}
	},`

@sdetweil
Copy link
Owner

sdetweil commented Jul 1, 2025

npm run config:check

reports it too?

we updated the syntax checker to catch literals in the wrong place, but i havent seen this on my system

@gonzonia
Copy link
Author

gonzonia commented Jul 1, 2025

No.
pi@MagicMirror:~/MagicMirror $ npm run config:check

[email protected] config:check
node js/check_config.js

[2025-07-01 17:56:29.538] [INFO] Checking config file /home/pi/MagicMirror/config/config.js ...
[2025-07-01 17:56:29.791] [INFO] Your configuration file doesn't contain syntax errors :)
[2025-07-01 17:56:29.793] [INFO] Checking modules structure configuration ...
[2025-07-01 17:56:30.034] [INFO] Your modules structure configuration doesn't contain errors :)

@gonzonia
Copy link
Author

gonzonia commented Jul 2, 2025

I found the problem. At some point I messed up something in node_helper with a bad cut and paste. Working on fixing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants