Skip to content

Fix handling null resultset coming back from GetEntityDataByFetchSearch #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seanmcne wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix handling null resultset coming back from GetEntityDataByFetchSearch #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4890719
Fix handling null resultset coming back from GetEntityDataByFetchSearch
seanmcne Nov 9, 2022
6410cff
removing files not required for release
seanmcne Nov 9, 2022
73c9675
Update
seanmcne Nov 9, 2022
60ccba8
Updates to manifest
seanmcne Nov 9, 2022
bf78bd9
pushing alpha classification in manifest
seanmcne Nov 9, 2022
e326590
Removing prerelease from the manifest
seanmcne Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Microsoft.Xrm.Data.PowerShell/Microsoft.Xrm.Data.PowerShell.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
RootModule = 'Microsoft.Xrm.Data.Powershell.psm1'

# Version number of this module.
ModuleVersion = '2.8.17'
ModuleVersion = '2.8.19'

# ID used to uniquely identify this module
GUID = '7df9c140-65c3-4862-b3bc-73fad633aae4'
Expand Down Expand Up @@ -96,7 +96,7 @@ AliasesToExport = @('*')
ModuleList = @()

# List of all files packaged with this module
FileList = @('Microsoft.Bcl.AsyncInterfaces.dll','Microsoft.Crm.Sdk.Proxy.dll','Microsoft.IdentityModel.Clients.ActiveDirectory.dll','Microsoft.IdentityModel.Clients.ActiveDirectory.Platform.dll','Microsoft.QualityTools.Testing.Fakes.dll','Microsoft.Rest.ClientRuntime.dll','Microsoft.Xrm.Sdk.Deployment.dll','Microsoft.Xrm.Sdk.dll','Microsoft.Xrm.Sdk.Workflow.dll','Microsoft.Xrm.Tooling.Connector.dll','Microsoft.Xrm.Tooling.CrmConnectControl.dll','Microsoft.Xrm.Tooling.CrmConnector.Powershell.dll','Microsoft.Xrm.Tooling.Ui.Styles.dll','Newtonsoft.Json.dll','System.Buffers.dll','System.Memory.dll','System.Numerics.Vectors.dll','System.Runtime.CompilerServices.Unsafe.dll','System.Text.Encodings.Web.dll','System.Text.Json.dll','System.Threading.Tasks.Extensions.dll','System.ValueTuple.dll','Microsoft.Xrm.Data.PowerShell.psm1','Microsoft.Xrm.Tooling.CrmConnector.PowerShell.psm1','Microsoft.Xrm.Data.PowerShell.psd1','Microsoft.Xrm.Tooling.CrmConnector.PowerShell.psd1','Microsoft.Xrm.Data.PowerShell.Help.xml','Microsoft.Xrm.Tooling.CrmConnector.Powershell.dll-Help.xml')
FileList = @('Microsoft.Bcl.AsyncInterfaces.dll','Microsoft.Crm.Sdk.Proxy.dll','Microsoft.IdentityModel.Clients.ActiveDirectory.dll','Microsoft.IdentityModel.Clients.ActiveDirectory.Platform.dll','Microsoft.QualityTools.Testing.Fakes.dll','Microsoft.Rest.ClientRuntime.dll','Microsoft.Xrm.Sdk.Deployment.dll','Microsoft.Xrm.Sdk.dll','Microsoft.Xrm.Sdk.Workflow.dll','Microsoft.Xrm.Tooling.Connector.dll','Microsoft.Xrm.Tooling.CrmConnectControl.dll','Microsoft.Xrm.Tooling.CrmConnector.Powershell.dll','Microsoft.Xrm.Tooling.Ui.Styles.dll','Newtonsoft.Json.dll','System.Buffers.dll','System.Memory.dll','System.Numerics.Vectors.dll','System.Runtime.CompilerServices.Unsafe.dll','System.Text.Encodings.Web.dll','System.Text.Json.dll','System.Threading.Tasks.Extensions.dll','System.ValueTuple.dll','Microsoft.Xrm.Data.PowerShell.psm1','Microsoft.Xrm.Data.PowerShell.psd1','Microsoft.Xrm.Data.PowerShell.Help.xml','Microsoft.Xrm.Tooling.CrmConnector.Powershell.dll-Help.xml')

# Private data to pass to the module specified in RootModule/ModuleToProcess. This may also contain a PSData hashtable with additional module metadata used by PowerShell.
PrivateData = @{
Expand All @@ -116,10 +116,11 @@ PrivateData = @{
# ReleaseNotes of this module
ReleaseNotes = '
Changes and enhancements in this release:
- Handling null results from connector library when there are no results from fetch
- Changed Enable-CrmLanguagePack to use Async it will prevent powershell timeouts and make it consistent with the same action taken in the UI
- For samples visit the community sample site here: https://github.com/seanmcne/Microsoft.Xrm.Data.PowerShell.samples
- Including latest xrm tooling 3.3.0.964 review the following website for release notes: https://www.powershellgallery.com/packages/Microsoft.Xrm.Tooling.CrmConnector.PowerShell/'
# Prerelease = '-alpha'
# Prerelease = 'alpha'

} # End of PSData hashtable
} # End of PrivateData hashtable
Expand Down
12 changes: 8 additions & 4 deletions Microsoft.Xrm.Data.PowerShell/Microsoft.Xrm.Data.PowerShell.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,10 +1684,14 @@ function Get-CrmRecordsByFetch{
{
throw LastCrmConnectorException($conn)
}

$recordsList.AddRange([System.Collections.Generic.List[System.Management.Automation.PSObject]](parseRecordsPage -records $records -logicalname $logicalName -xml $xml -Verbose))

$PageNumber = $PageNumber + 1
if($records -ne $null){
$recordsList.AddRange([System.Collections.Generic.List[System.Management.Automation.PSObject]](parseRecordsPage -records $records -logicalname $logicalName -xml $xml -Verbose))
$PageNumber = $PageNumber + 1
}
else{
#resultset is null - break out of loop and return an empty result
break
}
} while ($NextPage -and $AllRows)
}
catch
Expand Down
Loading