Draft: PostRecoverySQL #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhammer
commented
May 2, 2025
Comment on lines
+105
to
+116
| func executeQueries(db *sql.DB, queries []string) error { | ||
| for _, sqlQuery := range queries { | ||
| log.Debug("Executing query", "sqlQuery", sqlQuery) | ||
| _, err := db.Exec(sqlQuery) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
i intentionally do this here rather than in InitInfo (https://github.com/cloudnative-pg/cloudnative-pg/blob/2fb0189d4efa1a927684d30ebcdfa56e5f74e8ae/pkg/management/postgres/initdb.go#L421-L435) as it seems like the recovery steps are already using that interface a bit awkwardly
Comment on lines
+87
to
+89
| instance := info.GetInstance() | ||
|
|
||
| dbSuperUser, err := instance.GetSuperUserDB() |
There was a problem hiding this comment.
- no idea if either of these methods will succeed as the restore process is tapping into some of the shared initdb
Infofunctionality without being bootstrapped the same way that initdb dbs are. - i'm a little unclear how we'd know which user to use to run our statements against. since it's from a restore, we don't really know the user names, right? we don't know for sure if there is a root
postgresuser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with a solution for cloudnative-pg#6087