report/html/styles: fix link colours #1098
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap uses --*-rgb style vars to construct colours via css functions, like rgba(). The light-dark() css function only handles colours, it does not work with rgb tuples as arguments. Instead of using light-dark(), define all --*-rgb vars within media queries. Signed-off-by: Valentin Kunz <[email protected]>
|
Merged manually, thanks. Please have a look at b129b36 to ensure that I did not break something while resolving the conflict. |
|
LGTM, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi,
adding dark mode support broke anchor/link colours.
Bootstrap --*-rgb style vars are not compatible with light-dark(), as they contain rgb tuples, and light-dark() requires css colours.
BR,
Valentin