Adopted fix for angular universal support #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1747 +/- ##
==========================================
+ Coverage 47.84% 47.97% +0.13%
==========================================
Files 47 47
Lines 1992 1999 +7
Branches 176 177 +1
==========================================
+ Hits 953 959 +6
- Misses 1035 1036 +1
Partials 4 4
Continue to review full report at Codecov.
|
|
@doom777 Any chance we can get this merged? |
|
@mehrad-rafigh yes, but there are many things that need to be changed |
|
@doom777 Thank you for your answer. Would you please mind pointing out, what still would need to be changed? |
pertsenga
force-pushed
the
laurent-fix-universal-pr-adopted
branch
from
6daff6c to
7e8f0ca
Compare
pertsenga
force-pushed
the
laurent-fix-universal-pr-adopted
branch
from
7e8f0ca to
1cde2d2
Compare
pertsenga
changed the title
ghost
reviewed
Oct 29, 2019
pertsenga
force-pushed
the
laurent-fix-universal-pr-adopted
branch
from
3476a67 to
8017716
Compare
ghost
reviewed
Oct 31, 2019
dockleryxk
reviewed
Oct 31, 2019
|
Ok, so remove tsconfig changes, and merge, and I'll do a final check |
pertsenga
force-pushed
the
laurent-fix-universal-pr-adopted
branch
from
8017716 to
255841f
Compare
pertsenga
force-pushed
the
laurent-fix-universal-pr-adopted
branch
from
255841f to
0d8355f
Compare
ghost
approved these changes
Nov 6, 2019
ghost
merged commit
|
Is this going to be released soon? Eagerly waiting for it :) |
|
Whenever @SebastianM is back in contact |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopted #1554 for #1052 fix