Fix: Add type annotation and override PcapReader's __iter__ for mypy static type checking #4803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a mypy type-checking issue where PcapReader's
__next__
method was inferred to return atuple[bytes, PacketMetadata]
instead of a Packet due to inheriting__iter__
declaration of RawPcapReader.Changes
Overridden
__iter__()
method explicitly in PcapReader, with a type hint to indicate that PcapReader is an iterator over Packet objects.Note: No test was added as no runtime behavior was changed.
fixes #4728