update jobconfig related code causing by refactor job conf

[tyrone-yu]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @tyrone-yu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring of the job configuration management system. The primary goal is to enhance the clarity and robustness of how various execution parameters are defined, inherited, and applied during the lifecycle of a job. By deprecating an older configuration structure and integrating its functionality into the main job configuration, and by centralizing the merging logic, the changes ensure a more streamlined and predictable configuration flow for all operations.

Highlights

• Configuration Refactoring: The pull request refactors how job configurations are handled, centralizing the merging of job-specific settings with project-level defaults using brokerutil.UpdateJobConfig.
• Deprecation of RunningOptions: The RunningOptions protobuf message has been deprecated, and its Batched field functionality is now integrated directly into the JobConfig and CompileOptions for better consistency.
• New PSI Configuration: A new boolean field use_rr22_low_comm_mode has been added to PsiConfig, specifically for activating a low-communication mode when the PSI algorithm type is RR22.
• Expanded Configuration Parameters: Several configuration parameters, including Batched, UseRr22LowCommMode, EnableSessionLoggerSeparation, PsiType, and TimeZone, are now consistently propagated and managed across JobConfig, ProjectConfig, and session execution information.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors job configuration handling by moving settings like batched from the deprecated RunningOptions into JobConfig and ProjectConfig. This change allows for more granular control over job execution parameters and is applied consistently across protobuf definitions, service handlers, and tests. While the refactoring is a good improvement, I've identified two critical issues in pkg/broker/services/intra/query_handler.go. In both cases, there's a potential for a nil pointer dereference when accessing the new optional batched configuration, which could lead to a server panic. I've provided suggestions to fix these issues by using the safe getter method. Apart from these critical bugs, the refactoring is well-implemented.

[Song-Quan]

LGTM

[jingshi-ant]

LGTM