-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull in the IDESolver++ (aka. IterativeIDESolver) #733
Conversation
The solver is set-up in JF_N configuration from the paper "Scaling Interprocedural Static Data-Flow Analysis to Large C/C++ Applications: An Experience Report"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry, that it took a while. I had a little bit of other stuff to do 🙈
Btw. some of the extras and abstractions look a bit large and complicated overall. I'm not going to comment on the design here in particular. But maybe a few things could be simplified in the future.
unittests/PhasarLLVM/DataFlow/IfdsIde/IterativeIDESolverTest.cpp
Outdated
Show resolved
Hide resolved
unittests/PhasarLLVM/DataFlow/IfdsIde/IterativeIDESolverTest.cpp
Outdated
Show resolved
Hide resolved
include/phasar/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInteractionAnalysis.h
Outdated
Show resolved
Hide resolved
include/phasar/PhasarLLVM/DataFlow/IfdsIde/Problems/IDEInstInteractionAnalysis.h
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the 2 small things above left, otherwise this LGTM
Integrate the$JF_N$ configuration from the paper "Scaling Interprocedural Static Data-Flow Analysis to Large C/C++ Applications: An Experience Report" (https://doi.org/10.4230/LIPIcs.ECOOP.2024.36).
phasar-cli
tool