-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add mandatory test 6.1.37 #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 196-csaf-2.1
Are you sure you want to change the base?
Conversation
Coverage after merging 197-mandatory-test-6.1.37 into 196-csaf-2.1
Coverage Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please
- tighten the regex as discussed,
- check leap seconds/years
- use changed path from Disclosure date oasis-tcs/csaf#879
942047f
to
c257dcb
Compare
Coverage after merging 197-mandatory-test-6.1.37 into 217-csaf-2.1-test-script
Coverage Report
|
@tschmidtb51 Okay, I addressed the issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a few details
c257dcb
to
35a73ff
Compare
Coverage after merging 197-mandatory-test-6.1.37 into 196-csaf-2.1
Coverage Report
|
35a73ff
to
b5d6a72
Compare
Coverage after merging 197-mandatory-test-6.1.37 into 196-csaf-2.1
Coverage Report
|
@tschmidtb51 I added the check for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments. I guess we should discuss that in our meeting.
0bedc3b
to
0491638
Compare
Coverage after merging 197-mandatory-test-6.1.37 into 196-csaf-2.1
Coverage Report |
0491638
to
5c98f79
Compare
Coverage after merging 197-mandatory-test-6.1.37 into 196-csaf-2.1
Coverage Report |
Coverage after merging 197-mandatory-test-6.1.37 into 196-csaf-2.1
Coverage Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment.
Also, I ran the test and was reported issues for:
- 2015-06-30T10:29:60-13:30 -> true
- 2015-07-01T06:59:60+07:00 -> true
- 2017-01-01T02:59:60+03:00 -> true
What am I missing?
42a5e38
to
61dae22
Compare
Interesting. I can't reproduce that. Can you attach your test files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the tests locally and the test: oasis_csaf_tc-csaf_2_1-2024-6-1-37-13.json failed.
The check of the "disclosure_date": "2016-12-31T00:00:60+23:59", failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rainer-exxcellent: It was fixed with oasis-tcs/csaf#946 - you might need to update the csaf
submodule.
- update ajv-formats library - mandatory test 6.1.37: this now validates dates using ajv
61dae22
to
824e2fe
Compare
Coverage after merging 197-mandatory-test-6.1.37 into 196-csaf-2.1
Coverage Report |
No description provided.