196 csaf 2.1 optional test 6.2.28 #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging 196-csaf-2.1_optional_test_6.2.28 into main
Coverage Report |
domachine
reviewed
Apr 25, 2025
|
|
||
| const ajv = new Ajv() | ||
|
|
||
| const MAX_UUID = 'ffffffff-ffff-ffff-ffff-ffffffffffff' |
There was a problem hiding this comment.
Here you can move the file csaf_2_1/mandatoryTests/sharingGroup.js one level up and reference MAX_UUID identifier from there.
| const sharingGroup = doc.document.distribution.sharing_group | ||
| if (sharingGroup.id === MAX_UUID) { | ||
| ctx.warnings.push({ | ||
| message: 'The MAX UUID should not be used for the sharing group id.', |
There was a problem hiding this comment.
Other tests like "6.1.39" use the wording "Max UUID" to refer to the maximum uuid. I think we should be consistent here.
|
Coverage after merging 196-csaf-2.1_optional_test_6.2.28 into 196-csaf-2.1
Coverage Report |
|
Coverage after merging 196-csaf-2.1_optional_test_6.2.28 into 196-csaf-2.1
Coverage Report |
bendo-eXX
force-pushed
the
196-csaf-2.1_optional_test_6.2.28
branch
from
8507656 to
3d13c1b
Compare
|
Coverage after merging 196-csaf-2.1_optional_test_6.2.28 into 196-csaf-2.1
Coverage Report |
bendo-eXX
force-pushed
the
196-csaf-2.1_optional_test_6.2.28
branch
from
3d13c1b to
7ac90f2
Compare
|
Coverage after merging 196-csaf-2.1_optional_test_6.2.28 into 196-csaf-2.1
Coverage Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.