Feat/pausable #257
Merged
Feat/pausable #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
reviewed
Jan 28, 2025
|
I'll wait for input on the above comments, and on the common side(in case we also need to make changes there), before making any changes. |
Thomasvdam
force-pushed
the
feat/pausable
branch
from
ae8858a to
38ed5bc
Compare
mariocao
reviewed
Jan 29, 2025
Thomasvdam
force-pushed
the
feat/pausable
branch
from
38ed5bc to
3d1258d
Compare
|
mariocao
approved these changes
Jan 29, 2025
|
We didn't update the version in the cargo toml :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pausable behavior adds safety in case something goes wrong.
Explanation of Changes
Adds pause and unpause exec methods, checking if you are owner first.
These methods just always pause/unpause rather than erroring if they are already in that state. Let me know if this should be changed.
Querying dr's by status returns an empty list when contract is paused.
Sudo methods do not work while the contract is paused.
We also have a query to check the paused state of the contract.
Was unsure if this should pause the other DR queries/executions?
I didn't update the version in the toml yet, because was unsure if this dictates a minor or patch change :x
Testing
New tests added.
Related PRs and Issues
Waiting for sedaprotocol/seda-common-rs#39 to be merged first.
Closes #256.