Fully refund DRs resolved while contract is paused #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluax
approved these changes
Feb 6, 2025
hacheigriega
approved these changes
Feb 7, 2025
hacheigriega
reviewed
Feb 7, 2025
To prevent data requests being stuck in the contract while it is paused and potentially resolving a lot later when the data is already stale we continue expiring and processing data requests. Any DR resolved while the contract is paused will get an error result and trigger a full refund for the poster of the DR.
Thomasvdam
force-pushed
the
feat/paused-contract
branch
from
318ff52 to
9b59649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To prevent data requests being stuck in the contract while it is paused and potentially resolving a lot later when the data is already stale we continue expiring and processing data requests. Any DR resolved while the contract is paused will get an error result and trigger a full refund for the poster of the DR.
Explanation of Changes
Support the new contract DR list response which also returns the paused status. If the contract is paused all DRs will be resolved with an error and a full refund.
Cleaned up some test WASM binaries that were not being used.
Refactored the integration tests a little to make the paused test easier to set up.
Testing
Added an integration test with the latest version of the contract.
Related PRs and Issues
N.A.