feat(blocksize): refactor with the changes they asked for - #18
Merged
Conversation
Thomasvdam
reviewed
Sep 5, 2025
Comment on lines
+129
to
+134
| let timestamp = response_data | ||
| .get(field) | ||
| .and_then(|ts| ts.as_u64()) | ||
| .ok_or_else(|| anyhow!("{field} not found in response or is invalid"))?; | ||
| log!("Fetched {field}: {timestamp:?}"); | ||
| (timestamp as u128).to_le_bytes() |
Member
There was a problem hiding this comment.
I guess I'm missing something but doesn't this basically convert the ts field to a uint128 and gets processed as a price in the tally?
Collaborator
Author
There was a problem hiding this comment.
The only thing done in the tally is median. So they said median timestamp following along the data was fine too :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make the changes blocksize asked for.
Explanation of Changes
You can now pass in the fields you want from the API response. By default, does all fields from the response, minus the ticker.
It does the median for each, and it returns an
uint256[].Testing
Modified the tests and tested on testnet.
Related PRs and Issues
N/A