Update workflow context to point to bioschemas and add dct namespace636 compact computational workflow#2556
Merged
Merged
Conversation
# Conflicts: # lib/seek/bio_schema/resource_decorators/base_decorator.rb # test/unit/bio_schema/schema_ld_generation_test.rb
merge bioschema changes
…ow' into bioschemas-fixes # Conflicts: # lib/seek/bio_schema/resource_decorators/workflow.rb # test/unit/bio_schema/data_dump_test.rb
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SEEK’s Bioschemas/Schema.org JSON-LD generation to use an inline @context with @vocab and a dct prefix, and extends Workflow/SOP/Event/Sample contexts with Bioschemas terms so generated JSON-LD can be compacted/validated more cleanly (notably for ComputationalWorkflow/FormalParameter and dct:conformsTo).
Changes:
- Switch Schema.org context handling to an object-based
@context(@vocab+dct) and merge in additional context gathered from associated resources. - Add explicit Bioschemas mappings for Workflow (ComputationalWorkflow, FormalParameter, input/output), SOP (LabProtocol, computationalTool), Event (contact/hostInstitution/eventType), and Sample type; align Sample
PropertyValuefield topropertyID. - Update tests and bump
ro-crategem version and expected RO-Crate context version.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
lib/seek/bio_schema/serializer.rb |
Introduces @vocab + dct context constants and merges in additional context after attribute generation. |
lib/seek/bio_schema/resource_decorators/base_decorator.rb |
Makes decorator context an object (with @vocab/dct) and accumulates additional context from associated resources. |
lib/seek/bio_schema/resource_decorators/workflow.rb |
Adds Bioschemas term mappings for Workflow types and input/output/formal parameters. |
lib/seek/bio_schema/resource_decorators/sop.rb |
Adds Bioschemas LabProtocol/computationalTool mappings to SOP context. |
lib/seek/bio_schema/resource_decorators/sample.rb |
Adds Sample type mapping and updates propertyId → propertyID for Schema.org compliance. |
lib/seek/bio_schema/resource_decorators/event.rb |
Adds Bioschemas term mappings for Event-specific properties into context. |
lib/seek/bio_schema/resource_decorators/person.rb |
Removes Person conformance emission from this decorator. |
lib/seek/bio_schema/resource_decorators/organism.rb |
Fixes grammar in decorator comment (“an Organism”). |
test/unit/bio_schema/schema_ld_generation_test.rb |
Updates expected @context structure and adds schema.org term validation checks. |
test/unit/bio_schema/decorator_test.rb |
Updates decorator context expectation to match new object-based context. |
test/unit/bio_schema/data_dump_test.rb |
Adjusts dump size expectation to reflect updated output. |
test/unit/ro_crate/workflow_crate_test.rb |
Updates expected RO-Crate version in conformsTo. |
Gemfile.lock |
Bumps ro-crate gem from 0.6.0 to 0.7.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
52d2a27 to
7334db3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates Update workflow context to point to bioschemas and add dct namespace #2482 combined with bioschemas additions #2553
Partly resolves Workflow validation against bioschemas profile - description of errors #781 and Compact ComputationalWorkflow JSON-LD against schema.org context #636
Extend the context to add bioschemas terms used in Workflows.
Extend the context to add dct namespace
Already approved but waiting for RO-Crate synchronization ( see #2482 (review) )