fix: read the settings response message before disconnecting - #322
Open
njuro wants to merge 1 commit into
Open
Conversation
On OkHttpURLConnection, disconnect() closes the response and marks the connection as not connected; getResponseMessage() then reconnects, so a failed settings fetch sent the request twice and never closed the second response. OkHttp reported it as a leaked connection.
njuro
marked this pull request as ready for review
August 27, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RequestFactory.settings()handles a non-200 reply asWith the OkHttp-backed
OkHttpURLConnection(HTTP client v2),disconnect()closes the response and setsconnected = false, andgetResponseMessage()then callsconnect()again. So every failed settings fetch sends the request a second time, and that secondResponseis never closed. OkHttp reports it a few minutes later:Reproduces with any non-200 from the CDN — an invalid write key, or a transient CDN error — once per
Analyticsinstance percheckSettings().Fix
Read
responseMessageinto a local beforedisconnect(). One request is made and closed; the exception message is unchanged.