Skip to content

fix: fixed race condition causing events to be lost during initialization #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: fixed race condition causing events to be lost during initialization #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4226d5e
fix: fixed race condition causing events to be lost during initializa…
Oct 27, 2025
a85f29f
fix: race condition to prevent loss of events during initialisation
Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/core/src/__tests__/methods/process.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ describe('process', () => {
jest.spyOn(client.isReady, 'value', 'get').mockReturnValue(true);
// @ts-ignore
await client.onReady();
// @ts-ignore
await client.processPendingEvents();
expectedEvent = {
...expectedEvent,
context: { ...store.context.get() },
Expand Down
18 changes: 10 additions & 8 deletions packages/core/src/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,13 @@ export class SegmentClient {
// check if the app was opened from a deep link
this.trackDeepLinks(),
]);

await this.onReady();
this.isReady.value = true;

// Process all pending events
await this.processPendingEvents();
// Trigger manual flush
this.flushPolicyExecuter.manualFlush();
} catch (error) {
this.reportInternalError(
new SegmentError(
Expand Down Expand Up @@ -561,15 +565,13 @@ export class SegmentClient {
// Start flush policies
// This should be done before any pending events are added to the queue so that any policies that rely on events queued can trigger accordingly
this.setupFlushPolicies();

// Send all events in the queue
}
private async processPendingEvents() {
const pending = await this.store.pendingEvents.get(true);
for (const e of pending) {
await this.startTimelineProcessing(e);
await this.store.pendingEvents.remove(e);
for (const event of pending) {
await this.startTimelineProcessing(event);
await this.store.pendingEvents.remove(event);
}

this.flushPolicyExecuter.manualFlush();
}

async flush(): Promise<void> {
Expand Down
Loading