Skip to content

Fix typos for Eagle Eye (Actions) documentation #7744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025

Conversation

andreshernandez-e2x
Copy link
Contributor

Proposed changes

This fixes a typo and sets the (hopefully) proper format for a warning block.

Merge timing

  • ASAP once approved

@andreshernandez-e2x andreshernandez-e2x requested a review from a team as a code owner July 4, 2025 18:01
sade-wusi
sade-wusi previously approved these changes Jul 4, 2025
@sade-wusi sade-wusi self-requested a review July 4, 2025 18:33
Copy link

netlify bot commented Jul 4, 2025

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit ef562a0
🔍 Latest deploy log https://app.netlify.com/projects/segment-docs/deploys/686bb19707b828000843432a
😎 Deploy Preview https://deploy-preview-7744--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@andreshernandez-e2x
Copy link
Contributor Author

andreshernandez-e2x commented Jul 4, 2025

Note: I've based the warning on the visual tagger docs (/connections/sources/visual-tagger/) but it doesn't seem to be rendered in the same way. Please let me know if there's something missing so that the warning block renders correctly.

@sade-wusi
Copy link
Contributor

@andreshernandez-e2x The block should be rendering as normal now!

Tip: The callout blocks sometimes won't load if there's no line of whitespace before and after the callout. They also won't load if there's anything after the double quotes in the title line. (There was a sneaky little space after the quotes!)

@andreshernandez-e2x
Copy link
Contributor Author

Thanks @sade-wusi, looks correct now. These two bits were what I wanted to fix 👍

@sade-wusi sade-wusi added the fixed-content fix to content that has outdated or wrong information label Jul 7, 2025
@sade-wusi sade-wusi merged commit f76dac8 into segmentio:develop Jul 7, 2025
4 checks passed
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants