docs: fix Prometheus README snippet, remove nonexistent NewHandler() - #230
Merged
Merged
Conversation
Handler has never had a NewHandler constructor at any version (confirmed back through v4.7.2) -- it's a plain struct, used via a literal or the package's own DefaultHandler var. This snippet was added in 7e7070d alongside the OTLP exporter and appears to be a copy-paste from otlp.NewHandler (a real constructor on that subpackage). Anyone following the README as written gets a compile error. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prometheus.NewHandler(), which doesn't exist and never has (checked back through v4.7.2).Handleris a plain struct with no constructor.otlp.NewHandler, a real constructor on that subpackage.DefaultHandler, with a note that a&prometheus.Handler{}literal works too if you need to setTrimPrefix/MetricTimeout/Buckets.Test plan
DefaultHandlerand theHandlerstruct/fields exist as described, viahandler.goandhandler_test.go