Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake config file comments #1728

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix CMake config file comments #1728

wants to merge 1 commit into from

Conversation

enomis101
Copy link

  • Updated documentation comment to use PcapPlusPlus_INCLUDE_DIR instead of PcapPlusPlus_INCLUDE_DIRS to match actual variable name used in code
  • Removed PcapPlusPlus_LIBRARIES reference from comments as this variable is not defined anymore

@enomis101
Fix CMake config file to use PcapPlusPlus_INCLUDE_DIR consistently
6a79a0a 
- Changed PcapPlusPlus_INCLUDE_DIRS to PcapPlusPlus_INCLUDE_DIR in comments to match actual variable name
- Removed PcapPlusPlus_LIBRARIES reference from comments to align with target-based CMake practices
@enomis101 enomis101 requested a review from seladb as a code owner March 13, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigercosmos tigercosmos tigercosmos approved these changes

@egecetin egecetin egecetin approved these changes

@seladb seladb Awaiting requested review from seladb seladb is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enomis101 @tigercosmos @egecetin