Fix IPcapStatisticsProvider::getStatistics() unresolved symbol error when building without libpcap.#2146
Fix IPcapStatisticsProvider::getStatistics() unresolved symbol error when building without libpcap.#2146Dimi1010 wants to merge 8 commits into
IPcapStatisticsProvider::getStatistics() unresolved symbol error when building without libpcap.#2146Conversation
Remove `PcapDevice.cpp` file due to no implementation.
IPcapStatisticsProvider:;getStatistics to be implemented inline.IPcapStatisticsProvider::getStatistics() unresolved symbol error when building without libpcap.
|
CI pre-commit: Clang tidy is complaining because |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2146 +/- ##
========================================
Coverage 82.72% 82.73%
========================================
Files 332 331 -1
Lines 59807 59805 -2
Branches 12591 12297 -294
========================================
+ Hits 49475 49477 +2
+ Misses 8947 8920 -27
- Partials 1385 1408 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seladb
left a comment
There was a problem hiding this comment.
@Dimi1010 can you please fix the clang-tidy error https://github.com/seladb/PcapPlusPlus/actions/runs/26329991756/job/77568080302?pr=2146 ?
It looks like it still looks for PcapDevice.cpp for some reason 🤔
Should be fixed by ea0ef85. It adds a diff filter to exclude newly deleted files from being added to the list of files to check. |
This PR cleans up a potential unresolved symbol error due to
PcapDevice.hbeing always included andPcapDevice.cpponly being conditionally included inpcapbuilds. The inlining solution was chosen due toPcapDevice.cppcontaining only a single small function.The
PcapDevice.cppfile is removed after the move due to having no implementation details.Additional notes:
getStatistics()method has the same defect asIFilterableDevice::setFilterhad in Remove possibility ofsetFilterandclearFiltershadowing in derived devices. #2005.