Support modify comment #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w41ter
approved these changes
Aug 28, 2024
|
Hi, @smallx, sorry to have kept you waiting for so long. Since the old ccr syncer cannot recognize the newly added binlog type, I plan to merge the PRs for adding these binlog types after the next version (doris 2.1.6) is released. BTW, are you willing to add regression tests for these newly added binlog types? |
|
@w41ter Okay, I'll add some test cases. |
|
add regression tests: done |
|
@smallx please resolve the conflicts. |
smallx
force-pushed
the
support-modify-comment
branch
from
2840771
to
cb46e67
Compare
|
@w41ter rebased branch dev |
w41ter
approved these changes
Oct 21, 2024
w41ter
pushed a commit
that referenced
this pull request
Nov 11, 2024
w41ter
pushed a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support modify comment, for Doris apache/doris#39783