Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap dynamically imported modules #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lmartins
Copy link

@estrattonbailey Hi Eric, sorry it took me a while to get to this, but played with a small change that I think is working pretty great to allow Webpack's dynamic imports.

This commit checks if the loaded instance is a promise, unwraps it if it is, and then instantiate the object as picoapp normally would.

#7

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant