Feature: Promised Components #15
Conversation
On picoapp.mount(), each component is now wrapped in a Promise.resolve, which has the following consequences: 1. You can now asynchronously pass components to `picoapp` and `appInstance.add`. 1. Picoapp requires that `Promise` be polyfilled for browsers that don’t support it. 1. `appInstance.mount()` returns a `Promise` that resolves when all components have been successfully resolved and bound to the DOM.
| @@ -9,6 +9,8 @@ | |||
| > [operator](https://github.com/estrattonbailey/operator) – where page | |||
| > transitions can make conventional JS patterns cumbersome. | |||
|
|
|||
| **Note**: You’ll need to polyfill `Promise` for browsers that don’t support it. | |||
|
@estrattonbailey Eric, any chance we could get an update on this? |
|
@estrattonbailey @bro-strummer would be really cool if we could get an update on this, either to say we will be moving in this direction, or not. |
|
Hey, I'm sorry y'all. Just moved from NYC to Chicago and haven't been online much. Hoping to get around to some open source over the holidays, starting next week. |
|
@bro-strummer I'm struggling to use your version when using Parcel for code splitting. Parcel gives me a promise, but when I try to give picoapp the resolved promise for some reason the component never gets the node element, just the state. Have you seen something like that? EDIT: Nevermind, it was a problem resolving the default export from the imported module. |
|
Closing this! Having revisited the project that inspired this PR with fresh eyes, I now see that this feature—and thus my forked package, picoapp-async—wasn’t strictly necessary for my use case 🤦. I don’t plan on maintaining the forked package and will eventually be unpublishing it from NPM, so as not to clutter the ecosystem with abandonware. |
Hey @estrattonbailey! Really loving this library. It’s been a perfect "small-but-mighty" solve for a few projects of mine.
This PR effectively solves #7 but without baking in
module.defaultresolution. Pass anyPromisethat resolves the value of acomponentcall.Though the API remains unchanged, I might consider this a breaking feature for the fact that
mountis asynchronous. Might trip up some folks that callappInstance.emit()(or whatever) immediately afterappInstance.mount().I’ve updated tests and the readme. I thought grouping these readme additions alongside the explainer on the
addmethod might make sense.Let me know what you think! Cheers!
Feature Summary
Each passed component is now wrapped in a
Promise.resolve, which has the following consequences:picoappandappInstance.add.Promisebe polyfilled for browsers that don’t support it.appInstance.mount()returns aPromisethat resolves when all components have been successfully resolved and bound to the DOM.