Feature/issue 64 include scope #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfriedwolf
commented
Jan 24, 2023
Command/ExportCommand.php
Outdated
| "Scope name, multiple values can be comma separated; exports only those scopes.\n". | ||
| "\t\tTo export only specific scopes add there ID(s) using a colon and separate them with semicolon.\n". | ||
| "\t\tMake sure to use quotes when specifying multiple scope IDs:\n". | ||
| "\t\te.g. --includeScope=\"websites:2;3,stores:2;3;4;5\" will export the settings for website IDs 2 and 3 and for the\n". |
Author
There was a problem hiding this comment.
I noticed only afterwards, that separating scope IDs will break the command line. But I could not think of any better separator
Author
|
Hi @therouv , I fixed the cs-fixer-issues, but I do not understand what might have caused the Unit-Test failure.
What does Best regards, Willi |
Author
|
@therouv Could you please start the tests to see, if they work now? Thank you! |
|
Hi guys, this is a super important feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR - thank you!
Issue
This PR fixes issue #64 .
Proposed changes
Just allows to specify scope with ids (and without additional option) like:
--includeScope=websites:2,stores:2,3...