This repository was archived by the owner on Oct 28, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
add basic oauth flow #134
Open
DrewDennison
wants to merge
10
commits into
main
Choose a base branch
from
dd/add-oauth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add basic oauth flow #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Fixes #41 |
kurt-r2c
suggested changes
Aug 15, 2025
Collaborator
kurt-r2c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per offline conversation, at minimum we should have unit tests for audience/issuer verification
kurt-r2c
reviewed
Aug 15, 2025
This requires changing the call to FastMCP server and dropping DEFAULT_TIMEOUT Fixes #85 Signed-off-by: Flavio Percoco <[email protected]> Co-authored-by: Brandon Wu <[email protected]>
kurt-r2c
approved these changes
Aug 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using https://workos.com/docs/authkit/mcp
https://github.com/modelcontextprotocol/python-sdk?tab=readme-ov-file#authentication
DO NOT merge until signin page is built out and the jwt's validate against our API (Q3 WIP by F&S)