fix(windows): reduce Cygwin homepage fragility #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefAlsuhaibani
approved these changes
Dec 19, 2025
yosefAlsuhaibani
left a comment
yosefAlsuhaibani
left a comment
There was a problem hiding this comment.
Lgtm! I wonder if we can log what we got from get(cygwin.com) to confirm if it was us getting rate limited.
| if (version !== null) { | ||
| return version; | ||
| } else { | ||
| throw new Error("Couldn't parse Cygwin version from homepage"); |
There was a problem hiding this comment.
Q: is there a way to inspect errors like in CI in datadog? just interested in case we want to look up how many times this has come up.
Author
There was a problem hiding this comment.
We could start sending CI logs to Datadog, but I think that's expensive. We can at least monitor how often the setup-ocaml step specifically fails.
|
Also it seems like the upstream has abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like sometimes the Cygwin homepage does not contain its version in the format setup-ocaml expects. This causes the tool cache to complain about an empty version: https://github.com/semgrep/semgrep-proprietary/actions/runs/20381063339/job/58571399243?pr=5267 and perhaps cause higher-level caching issues too.
This PR
actions/cacheuse).